Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing attribute for progressbar #31

Merged
merged 2 commits into from
May 7, 2024
Merged

Add missing attribute for progressbar #31

merged 2 commits into from
May 7, 2024

Conversation

milia20
Copy link
Contributor

@milia20 milia20 commented May 7, 2024

Description

The progressbar was missing an "maximum" attribute, so I added it.
Tested, values ​​change correctly.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings or regressions

ObaraEmmanuel
ObaraEmmanuel requested changes May 7, 2024
View reviewed changes
Copy link
Owner

@ObaraEmmanuel ObaraEmmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Seems I missed this property. Move the property to above maxundo to maintain the sorting and I think it will be good to merge.

@milia20 milia20 requested a review from ObaraEmmanuel May 7, 2024 19:05
ObaraEmmanuel
ObaraEmmanuel approved these changes May 7, 2024
View reviewed changes
Copy link
Owner

@ObaraEmmanuel ObaraEmmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the PR. I really appreciate it.

@ObaraEmmanuel ObaraEmmanuel merged commit 1b15777 into ObaraEmmanuel:master May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ObaraEmmanuel ObaraEmmanuel ObaraEmmanuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milia20 @ObaraEmmanuel